Skip to content

Update MTD Broker Bookmark usages through bookmark service #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 8, 2024

Conversation

samad-yar-khan
Copy link
Contributor

@samad-yar-khan samad-yar-khan commented Aug 8, 2024

Linked Issue(s)

#500

Acceptance Criteria fulfillment

  • Update usage of BookmarkService throughout the codebase
    • Update usages for MTD Broker bookmark

Proposed changes (including videos or screenshots)

  • Updated MergeToDeployCacheHandler to use BookmarkService in fetching and setting mtd broker bookmark.
  • Update MergeToDeployBrokerUtils to use BookmarkService in fetching and setting mtd broker bookmark.
  • Added method for get or set settings.
  • Updated syncs to use get_or_set_settings.

Further comments

@samad-yar-khan samad-yar-khan force-pushed the bookmark-service-usages branch from 92a2a0d to e6cd899 Compare August 8, 2024 12:40
jayantbh
jayantbh previously approved these changes Aug 8, 2024
adnanhashmi09
adnanhashmi09 previously approved these changes Aug 8, 2024
@samad-yar-khan samad-yar-khan merged commit bb38d40 into main Aug 8, 2024
3 checks passed
@samad-yar-khan samad-yar-khan deleted the bookmark-service-usages branch August 8, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants