gitlab integration apis #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samad-yar-khan
previously approved these changes
Jul 5, 2024
amoghjalan
suggested changes
Jul 5, 2024
Comment on lines
+112
to
+122
| gitlab_domain = ( | ||
| integrations[0].provider_meta.get("custom_domain") | ||
| if integrations[0].provider_meta | ||
| else None | ||
| ) | ||
|
|
||
| if not gitlab_domain: | ||
| LOG.warn( | ||
| f"Custom domain not found for intergration for org {org_id} and provider {UserIdentityProvider.GITLAB.value}" | ||
| ) | ||
| return DEFAULT_DOMAIN |
Contributor
There was a problem hiding this comment.
Would break for someone with github integration, and you are calling it irrespective of the provider
Contributor
Author
There was a problem hiding this comment.
Good catch. Thanks :)
amoghjalan
suggested changes
Jul 5, 2024
Comment on lines
137
to
150
| if user_identity_provider == UserIdentityProvider.GITHUB: | ||
| return ExternalIntegrationsService( | ||
| org_id, | ||
| user_identity_provider, | ||
| _get_access_token(), | ||
| ) | ||
|
|
||
| if user_identity_provider == UserIdentityProvider.GITLAB: | ||
| return ExternalIntegrationsService( | ||
| org_id, | ||
| user_identity_provider, | ||
| _get_access_token(), | ||
| _get_custom_gitlab_domain(), | ||
| ) |
Contributor
There was a problem hiding this comment.
Suggested change
| if user_identity_provider == UserIdentityProvider.GITHUB: | |
| return ExternalIntegrationsService( | |
| org_id, | |
| user_identity_provider, | |
| _get_access_token(), | |
| ) | |
| if user_identity_provider == UserIdentityProvider.GITLAB: | |
| return ExternalIntegrationsService( | |
| org_id, | |
| user_identity_provider, | |
| _get_access_token(), | |
| _get_custom_gitlab_domain(), | |
| ) | |
| custom_domain_name = None | |
| if user_identity_provider == UserIdentityProvider.GITLAB: | |
| custom_domain_name = _get_custom_gitlab_domain() | |
| return ExternalIntegrationsService( | |
| org_id, | |
| user_identity_provider, | |
| _get_access_token(), | |
| custom_domain_name | |
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issue(s)
Closes #467
Proposed changes (including videos or screenshots)
This PR introduces the following 3 apis:
/orgs/<org_id>/integrations/gitlab/groups- Method: GET/orgs/<org_id>/integrations/gitlab/user/repos- Method: GET/orgs/<org_id>/integrations/gitlab/groups/<group_id>/repos- Method: GET