feat(trpc): stable tRPC to oRPC router #808
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
size:S
WalkthroughThis change removes the "experimental_" prefix from several types and functions related to the oRPC integration in both implementation and documentation. All references, imports, and exports are updated to use the new stable names, with no changes to logic or behavior. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant tRPCRouter
participant toORPCRouter
participant oRPCRouter
User->>tRPCRouter: Provide tRPC router
tRPCRouter->>toORPCRouter: Pass router for conversion
toORPCRouter->>oRPCRouter: Return oRPC router instance
oRPCRouter-->>User: Ready for oRPC integration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Possibly related PRs
Suggested labels
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (5)
🧰 Additional context used🧬 Code Graph Analysis (1)packages/trpc/src/to-orpc-router.ts (4)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (9)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @unnoq, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request marks a significant step in the maturity of the tRPC integration by promoting its API to a stable state. The changes primarily involve renaming types and functions by removing their experimental_ prefixes, ensuring a more stable and predictable interface for consumers. This update is reflected across the core implementation, documentation, and test suite.
Highlights
- API Stability Promotion: The core tRPC integration features, previously marked as
experimental, have been promoted to stable. This involves removing theexperimental_prefix from key types and functions. - Type and Function Renaming: The
experimental_ORPCMetainterface is nowORPCMeta,experimental_ToORPCOutputis nowToORPCOutput, andexperimental_ToORPCRouterResultis nowToORPCRouterResult. Similarly, the main conversion functionexperimental_toORPCRouterhas been renamed totoORPCRouter. - Documentation and Test Updates: All references to the
experimental_prefixed names in documentation (trpc.md) and test files (to-orpc-router.test-d.ts,to-orpc-router.test.ts,shared.ts) have been updated to reflect the new stable names.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Code Review
This pull request promotes the tRPC integration to a stable feature by removing the experimental_ prefix from related functions, types, and interfaces. The changes are applied consistently across the implementation, tests, and documentation. The code modifications are straightforward renames and appear correct. The updated documentation accurately reflects these changes.
More templates
@orpc/arktype
@orpc/client
@orpc/contract
@orpc/experimental-durable-event-iterator
@orpc/hey-api
@orpc/json-schema
@orpc/nest
@orpc/openapi
@orpc/openapi-client
@orpc/react
@orpc/react-query
@orpc/server
@orpc/shared
@orpc/solid-query
@orpc/standard-server
@orpc/standard-server-aws-lambda
@orpc/standard-server-fetch
@orpc/standard-server-node
@orpc/standard-server-peer
@orpc/svelte-query
@orpc/tanstack-query
@orpc/trpc
@orpc/valibot
@orpc/vue-colada
@orpc/vue-query
@orpc/zod
commit: |
unnoq
changed the title
1 participant
Summary by CodeRabbit