Make RPC & OpenApi Serializer / Deserializer async

[KingSora]

Describe the feature

For simple serialization / deserilization (like e.g. for dates) the serializer API is enough. For more complex serialization like e.g. serializing crypto public keys, the entire webcrypto api is async.

An example for serializing a public key to a jwk (json web key):

const keyPair = await crypto.subtle.generateKey(
  {
    name: 'RSA-OAEP',
    modulusLength: 4096,
    publicExponent: new Uint8Array([1, 0, 1]),
    hash: 'SHA-256',
  },
  true,
  ['encrypt', 'decrypt'],
)
const serialized = await crypto.subtle.exportKey('jwk', keyPair.publicKey)

This can't be done with the current API. Willing to make a PR!

Additional information

• Would you be willing to help implement this feature?

[pullfrog]

  ^{｜ Build this ➔ ｜ Make a plan ➔}

[dinwwwh]

I personally don't like this feature. Serialization should be fast and shouldn't introduce side effects.

[dinwwwh]

Or just rely on sync node module:

import crypto from 'node:crypto'

const { publicKey, privateKey } = crypto.generateKeyPairSync('rsa', {
  modulusLength: 4096,
  publicExponent: 0x10001, // 65537
})

const serialized = publicKey.export({ format: 'jwk' })

[KingSora]

I personally don't like this feature. Serialization should be fast and shouldn't introduce side effects.

@dinwwwh I'm with you on should be fast and shouldn't introduce side effects, but I believe that serialization and deserialization should always have the possibility to be async. Just because an operation is async it doesn't mean that it is slow.

The fetch api would agree on that since const response = await fetch() will return a response and then the deserialization e.g. response.json() is also always async. Same with serilization and the request object - request.json(), also async.

icKey, privateKey } = crypto.generateKeyPairSync('rsa', {
modulusLength: 4096,
publicExponent: 0x10001, // 65537
})

const serialized = publicKey.export({ format: 'jwk' })

The crypto API was an example where the web standard enforces async operations. But think about it, trading generateKeyPairSync vs the async variant just blocks the whole process now for that time. Its the same reason why fs/promises should be preferred over fs sync operations.

[KingSora]

In case you really won't support that feature, please close the PR & the ticket... just wanted to make the project better and my life simpler

[dinwwwh]

Wait more people like this issue or close base on you.