fix: security hardening (7 findings from audit) - #904
Open
pointunbalance wants to merge 1 commit into
Open
Conversation
- Fix Polar webhook signature bypass fallback (MEDIUM) - Sanitize Content-Disposition filename to prevent header injection (MEDIUM) - Add path traversal rejection for '..' sequences (LOW) - Add startup warning for Worker admin dashboard without auth (LOW) - Add startup warning for Inbox webhook without Basic Auth (LOW) - Replace non-null assertions with proper env var checks (INFO) - Add Slack response_url validation as defense-in-depth (INFO)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses 7 security findings identified in a comprehensive security audit of the midday codebase.
Changes
Files Changed
Testing
All changes are defensive hardening with no behavioral changes to the happy path. The fixes follow existing code patterns in the codebase.