Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated round 18 projections to include age groups #287

Merged
merged 4 commits into from
Jun 24, 2024

Conversation

mooresea
Copy link
Contributor

Description

Added required age group projections. Increased number of trajectories per scenario from 100 to 200.

Checklist

  • Specify a proper PR title with your team name.
  • All validation checks ran successfully on your branch. Instructions to run the tests locally is present here.

Copy link

Run validation on files: 2024-04-28/cum death/2024-04-28-NotreDame-FRED0.gz.parquet, 2024-04-28/cum hosp/2024-04-28-NotreDame-FRED0.gz.parquet, 2024-04-28/inc death/2024-04-28-NotreDame-FRED0.gz.parquet, 2024-04-28/inc hosp/2024-04-28-NotreDame-FRED0.gz.parquet

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

❌ Error 510: Each group combination should have one unique value. 6364800 unique groups have been identified with this issue. For example:
group: 2024-04-28, A-2024-03-01, 02, inc death, 1, NA, sample, 1;
group: 2024-04-28, A-2024-03-01, 02, inc death, 2, NA, sample, 1;
group: 2024-04-28, A-2024-03-01, 02, inc death, 3, NA, sample, 1;
etc.

Target Columns:

No errors or warnings found in target and associated columns

Locations:

No errors or warnings found on Location

Sample:

❌ Error 904: Samples are expected in the submission for the target(s): inc death, inc hosp. please verify.

Quantiles:

No errors or warnings found on quantiles values and format

Age Group:

❌ Error 801: The age_group column should contain value written: 'AGEMIN-AGEMAX', one or more 'age_group' value(s) is not corresponding in the submission file, please verify: 'NA'.
❌ Error 802: The age_group column contains unexpected value: 'NA'. 'age_group' can only be: 0-130, 65-130, 0-64, for the target: inc death, inc hosp.
❌ Error 802: The age_group column is missing at least 1 required value: '0-130', '65-130', '0-64'. 'age_group' should contain: 0-130, 65-130, 0-64, for the target: inc death, inc hosp.

Copy link

If the submission contains projection file(s) with quantile projection, a pdf containing visualization plots of the submission might be available and downloadable in the GitHub actions. Please click on 'details' on the right of the 'Validate submission' checks. The pdf is available in a ZIP file as an artifact of the GH Actions. For more information, please see here

@LucieContamin
Copy link
Collaborator

Good afternoon @mooresea ,

If I can provide more information on the error messages: it seems that the main issue is the NA in the age_group column for the sample output type. It creates multiple errors that might be confusing in the validation report. Also as I reminder, it is important to have the same number of samples for every group.

Please let me know if any issue or questions,
Best,
Lucie

@mooresea
Copy link
Contributor Author

mooresea commented Jun 4, 2024 via email

Copy link

github-actions bot commented Jun 5, 2024

Run validation on files: 2024-04-28/cum death/2024-04-28-NotreDame-FRED0.gz.parquet, 2024-04-28/cum hosp/2024-04-28-NotreDame-FRED0.gz.parquet, 2024-04-28/inc death/2024-04-28-NotreDame-FRED0.gz.parquet, 2024-04-28/inc hosp/2024-04-28-NotreDame-FRED0.gz.parquet
End of validation check: all the validation checks were successful

Copy link

github-actions bot commented Jun 5, 2024

If the submission contains projection file(s) with quantile projection, a pdf containing visualization plots of the submission might be available and downloadable in the GitHub actions. Please click on 'details' on the right of the 'Validate submission' checks. The pdf is available in a ZIP file as an artifact of the GH Actions. For more information, please see here

@LucieContamin
Copy link
Collaborator

Hi @mooresea ,

Thank you for the update, I have a question about your submission, it seems that the file contains "sample" and "quantile" output type for all targets: cumulative and incident hospitalization and death. However, I noticed that your files do not contain cumulative hospitalization and death samples for the age group "0-130" but it's available for other age group. As the targets are optional, the validation did not send a message, but would it be possible to look into it, please?
I am happy to wait next week for next update if it's easier.

Please let me know if any issue or questions,
Best,
Lucie

@LucieContamin
Copy link
Collaborator

Hi again!

Sorry for the double message, but will it also be possible to remove your previous submission files to avoid issues.
Please let me know if any issue or questions,
Best,
Lucie

Copy link

Run validation on files: 2024-04-28/cum death/2024-04-28-NotreDame-FRED0.gz.parquet, 2024-04-28/cum hosp/2024-04-28-NotreDame-FRED0.gz.parquet, 2024-04-28/inc death/2024-04-28-NotreDame-FRED0.gz.parquet, 2024-04-28/inc hosp/2024-04-28-NotreDame-FRED0.gz.parquet
End of validation check: all the validation checks were successful

Copy link

If the submission contains projection file(s) with quantile projection, a pdf containing visualization plots of the submission might be available and downloadable in the GitHub actions. Please click on 'details' on the right of the 'Validate submission' checks. The pdf is available in a ZIP file as an artifact of the GH Actions. For more information, please see here

Copy link

Run validation on files: 2024-04-28/cum death/2024-04-28-NotreDame-FRED0.gz.parquet, 2024-04-28/cum hosp/2024-04-28-NotreDame-FRED0.gz.parquet, 2024-04-28/inc death/2024-04-28-NotreDame-FRED0.gz.parquet, 2024-04-28/inc hosp/2024-04-28-NotreDame-FRED0.gz.parquet
End of validation check: all the validation checks were successful

Copy link

If the submission contains projection file(s) with quantile projection, a pdf containing visualization plots of the submission might be available and downloadable in the GitHub actions. Please click on 'details' on the right of the 'Validate submission' checks. The pdf is available in a ZIP file as an artifact of the GH Actions. For more information, please see here

@LucieContamin
Copy link
Collaborator

Hi @mooresea,
Thank you for the update, it looks all good now.
Best, Lucie

@LucieContamin LucieContamin merged commit 7dcf370 into midas-network:master Jun 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants