One button system: adopt the four roles and gate them in CI

.github/workflows/dotnet-core-master.yml

@@ -28,6 +28,11 @@ jobs:
         cp -av eform-angular-outer-inner-resource-plugin/eform-client/src/app/plugins/modules/outer-inner-resource-pn eform-angular-frontend/eform-client/src/app/plugins/modules/outer-inner-resource-pn
         mkdir -p eform-angular-frontend/eFormAPI/eFormAPI.Web/Plugins
         cd eform-angular-frontend/eform-client && ../../eform-angular-outer-inner-resource-plugin/testinginstallpn.sh
+    - name: Button conventions
+      # The checker lives in the frontend repo (checked out above); these
+      # templates are ours. A frontend CI run cannot see them because
+      # src/app/plugins/ is gitignored there, so this plugin has to run it.
+      run: cd eform-angular-frontend/eform-client && node scripts/check-button-conventions.js src/app/plugins/modules/outer-inner-resource-pn
     - name: Get the version release
       id: get_release_version
       run: echo ::set-output name=VERSION::$(cd eform-angular-outer-inner-resource-plugin && git describe --abbrev=0 --tags | cut -d "v" -f 2)

.github/workflows/dotnet-core-pr.yml

@@ -25,6 +25,11 @@ jobs:
         cp -av eform-angular-outer-inner-resource-plugin/eform-client/src/app/plugins/modules/outer-inner-resource-pn eform-angular-frontend/eform-client/src/app/plugins/modules/outer-inner-resource-pn
         mkdir -p eform-angular-frontend/eFormAPI/eFormAPI.Web/Plugins
         cd eform-angular-frontend/eform-client && ../../eform-angular-outer-inner-resource-plugin/testinginstallpn.sh
+    - name: Button conventions
+      # The checker lives in the frontend repo (checked out above); these
+      # templates are ours. A frontend CI run cannot see them because
+      # src/app/plugins/ is gitignored there, so this plugin has to run it.
+      run: cd eform-angular-frontend/eform-client && node scripts/check-button-conventions.js src/app/plugins/modules/outer-inner-resource-pn
     - name: Get the version release
       id: get_release_version
       run: echo ::set-output name=VERSION::$(cd eform-angular-outer-inner-resource-plugin && git describe --abbrev=0 --tags | cut -d "v" -f 2)

eform-client/src/app/plugins/modules/outer-inner-resource-pn/modules/inner-resources/components/inner-resource-create/inner-resource-create.component.html

@@ -33,15 +33,14 @@ <h3 mat-dialog-title>{{'New' | translate}}</h3>
 </div>
 <div mat-dialog-actions class="d-flex flex-row justify-content-end">
   <button
-    mat-raised-button
-    color="accent"
+    class="btn-primary"
     id="innerResourceCreateSaveBtn"
     [disabled]="!newMachineModel.name"
     (click)="createMachine()">
     {{'Create' | translate}}
   </button>
   <button
-    mat-raised-button
+    class="btn-cancel"
     id="innerResourceCreateCancelBtn"
     (click)="hide()">
     {{'Cancel' | translate}}

eform-client/src/app/plugins/modules/outer-inner-resource-pn/modules/inner-resources/components/inner-resource-delete/inner-resource-delete.component.html

@@ -11,14 +11,13 @@ <h3 mat-dialog-title>{{'Are you sure you want to delete' | translate}}?</h3>
 </div>
 <div mat-dialog-actions class="d-flex flex-row justify-content-end">
   <button
-    mat-raised-button
-    color="warn"
+    class="btn-delete"
     id="innerResourceDeleteDeleteBtn"
     (click)="deleteMachine()">
     {{'Delete' | translate}}
   </button>
   <button
-    mat-raised-button
+    class="btn-cancel"
     id="innerResourceDeleteCancelBtn"
     (click)="hide()">
     {{'Cancel' | translate}}

eform-client/src/app/plugins/modules/outer-inner-resource-pn/modules/inner-resources/components/inner-resource-edit/inner-resource-edit.component.html

@@ -33,15 +33,14 @@ <h3 mat-dialog-title>{{'Update' | translate}}</h3>
 </div>
 <div mat-dialog-actions class="d-flex flex-row justify-content-end">
   <button
-    mat-raised-button
-    color="accent"
+    class="btn-primary"
     id="innerResourceEditSaveBtn"
     [disabled]="!selectedMachineModel.name"
     (click)="updateMachine()">
     {{'Save' | translate}}
   </button>
   <button
-    mat-raised-button
+    class="btn-cancel"
     id="innerResourceEditCancelBtn"
     (click)="hide()">
     {{'Cancel' | translate}}

eform-client/src/app/plugins/modules/outer-inner-resource-pn/modules/outer-resources/components/outer-resource-create/outer-resource-create.component.html

@@ -32,15 +32,14 @@ <h3 mat-dialog-title>{{'New Area' | translate}}</h3>
 </div>
 <div mat-dialog-actions class="d-flex flex-row justify-content-end">
   <button
-    mat-raised-button
-    color="accent"
+    class="btn-primary"
     id="outerResourceCreateSaveBtn"
     [disabled]="!newAreaModel.name"
     (click)="createArea()">
     {{'Create' | translate}}
   </button>
   <button
-    mat-raised-button
+    class="btn-cancel"
     id="outerResourceCreateCancelBtn"
     (click)="hide()">
     {{'Cancel' | translate}}

eform-client/src/app/plugins/modules/outer-inner-resource-pn/modules/outer-resources/components/outer-resource-delete/outer-resource-delete.component.html

@@ -11,14 +11,13 @@ <h3 mat-dialog-title>{{'Are you sure you want to delete' | translate}}?</h3>
 </div>
 <div mat-dialog-actions class="d-flex flex-row justify-content-end">
   <button
-    mat-raised-button
-    color="warn"
+    class="btn-delete"
     id="outerResourceDeleteDeleteBtn"
     (click)="deleteArea()">
     {{'Delete' | translate}}
   </button>
   <button
-    mat-raised-button
+    class="btn-cancel"
     id="outerResourceDeleteCancelBtn"
     (click)="hide()">
     {{'Cancel' | translate}}

eform-client/src/app/plugins/modules/outer-inner-resource-pn/modules/outer-resources/components/outer-resource-edit/outer-resource-edit.component.html

@@ -34,15 +34,14 @@ <h3 mat-dialog-title>{{'Update' | translate}}</h3>
 </div>
 <div mat-dialog-actions class="d-flex flex-row justify-content-end">
   <button
-    mat-raised-button
-    color="accent"
+    class="btn-primary"
     id="outerResourceEditSaveBtn"
     [disabled]="!selectedAreaModel.name"
     (click)="updateArea()">
     {{'Save' | translate}}
   </button>
   <button
-    mat-raised-button
+    class="btn-cancel"
     id="outerResourceEditCancelBtn"
     (click)="hide()">
     {{'Cancel' | translate}}