Do not use mutable default arguments #800
Conversation
Using mutable default arguments is a common Python problem, see e.g. https://docs.python-guide.org/writing/gotchas/#mutable-default-arguments In this specific case the default argument even tries to setup some infrastructure settings at import time, which can potentially fail. Note that this commit is changing the behavior for user passing in `None` to the changed method, as it will now create an `AsyncClient` with the options specified within the module. In the previous behavior it would have raised an exception deeper down the call stack (see http://github.com/microsoft/kiota-http-python/pull/383/files).
|
Note that this PR is done together with: |
|
@marlamb can you also replicate the change to https://github.com/microsoftgraph/msgraph-beta-sdk-python please? |
@baywet I would, but you were faster 😄 . Out of curiosity: what is the reason why it triggered releases on all repositories except for |
|
For core I found a defect in the release please configuration microsoftgraph/msgraph-sdk-python-core#628 For V1 and beta I ran into a defect with dependencies configuration which prevents the release. All those caused by recent changes in the automation. |
Thanks for the explanation, crossing fingers that you can fix the defects and looking forward to the releases! |
|
yes, service libraries were just released yesterday and today |
Using mutable default arguments is a common Python problem, see e.g. https://docs.python-guide.org/writing/gotchas/#mutable-default-arguments
In this specific case the default argument even tries to setup some infrastructure settings at import time, which can potentially fail.
Note that this commit is changing the behavior for user passing in
Noneto the changed method, as it will now create anAsyncClientwith the options specified within the module. In the previous behavior it would have raised an exception deeper down the call stack (see http://github.com/microsoft/kiota-http-python/pull/383/files).