Skip to content

Task/refactor packaging #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 21, 2022
Merged

Task/refactor packaging #144

merged 4 commits into from
Nov 21, 2022

Conversation

@samwelkanda
Copy link
Contributor

@samwelkanda samwelkanda commented Nov 21, 2022 •
edited
Loading

Overview

  • Refactors package structure to use src folder for easy installs
  • Switch from flit to setuptools for packaging and easier imports e.g
#old format
from msgraph.core.base_graph_request_adapter import BaseGraphRequestAdapter
#new format
from msgraph_core import BaseGraphRequestAdapter

@samwelkanda samwelkanda marked this pull request as ready for review November 21, 2022 13:03
@samwelkanda samwelkanda self-assigned this Nov 21, 2022
@samwelkanda samwelkanda merged commit 0487b2c into kiota/long-term-branch Nov 21, 2022
@samwelkanda samwelkanda deleted the task/refactor-packaging branch November 21, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baywet baywet baywet approved these changes

@andrueastman andrueastman Awaiting requested review from andrueastman

Assignees

@samwelkanda samwelkanda

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samwelkanda @baywet