identity governance: add remove statements for cmdlets generated for new EM Graph v1.0 APIs #984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwahl-msft
requested review from
ddyett,
georgend,
peombwa and
shemogumbe
as code owners
peombwa
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we bring APIs for Azure AD entitlement management into Graph v1.0 as part of identity governance, many of the APIs have updated paths. In particular, the beta APIs often used "AccessPackage" as a prefix for resource names, this is not present in the API for v1.0.
As a result, while the suppression rules in Identity.Governance readme.md for the beta APIs continue to be needed for the beta cmdlets which should not be auto-generated, additional rules are needed for the new paths that will be used in Graph v1.0.
This change updates the readme.md with additional rules to reduce the number of Entitlement Management cmdlets that are present in the v1.0 variant of the module. This specifically targets cmdlets which are traversals between two resources. While theoretically possible for a service to implement, the paths that many of these cmdlets emitted were not part of the documented entitlement management API for v1.0 either, so should be suppressed to avoid causing customer confusion.
Note that this change does not include cmdlets for assignment policy or access package resources, as those are not yet in Graph v1.0, a later change will update this readme.md further once those are part of Graph v1.0. Nor does this change update existing custom cmdlets so they are present in v1.0; that will be the subject of a separate change as well.