Skip to content

Identity governance: suppress Invoke-MgFilterEntitlementManagementCatalogAccessPackage #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Identity governance: suppress Invoke-MgFilterEntitlementManagementCatalogAccessPackage #1190

merged 2 commits into from
Apr 7, 2022

Conversation

markwahl-msft
Copy link
Contributor

Changes proposed in this pull request

In the Azure AD identity governance module, Invoke-Mg cmdlets are generated for the special-purpose filtering Microsoft Graph APIs for entitlement management, such as an access package or a catalog filterByCurrentUser. This PR is intended to suppress the automatic generation of one cmdlet in that module.

The URL that the Invoke-MgFilterEntitlementManagementCatalogAccessPackage cmdlet sends is a URL that is supported by entitlement management as part of its API surface.

(The other Invoke-Mg*EntitlementManagement* cmdlets for entitlement management should be unchanged by this PR. While those other ones are sending valid requests that are processed by the service, the cmdlets still fail when parsing the responses at present, because they don't realize that the OData response is a structure containing an array (and potentially a nextLink), rather than an array. That's the subject of a separate existing bug.)

@peombwa
Copy link
Member

peombwa commented Apr 5, 2022

@markwahl-msft, should we also remove ContainsTarget="true" from accessPackages NavigationProperty in accessPackageCatalog entity if /identityGovernance/entitlementManagement/catalogs/{accessPackageCatalog-id}/accessPackages* is not supported by the service? ContainsTarget=true is what we rely on to expand the paths:

<EntityType Name="accessPackageCatalog" BaseType="graph.entity">
  <Property Name="catalogType" Type="graph.accessPackageCatalogType" />
  <Property Name="createdDateTime" Type="Edm.DateTimeOffset" />
  <Property Name="description" Type="Edm.String" />
  <Property Name="displayName" Type="Edm.String" />
  <Property Name="isExternallyVisible" Type="Edm.Boolean" />
  <Property Name="modifiedDateTime" Type="Edm.DateTimeOffset" />
  <Property Name="state" Type="graph.accessPackageCatalogState" />
  <NavigationProperty Name="accessPackages" Type="Collection(graph.accessPackage)" ContainsTarget="true" />
</EntityType>

@markwahl-msft
Copy link
Contributor Author

ContainsTarget=true is what we rely on to expand the paths

That is a good question. One of the challenges is that today Graph is using this for two semantically distinct concepts - logical containment relationship of one type of resource to another, and URL navigation between those resources. Perhaps in the future there will be different tagging properties for these two different cases.

@markwahl-msft
Copy link
Contributor Author

#sign-off

@peombwa peombwa merged commit 207e8a1 into microsoftgraph:dev Apr 7, 2022
@markwahl-msft markwahl-msft deleted the mwahl-em1-noinv branch April 8, 2022 15:11
@peombwa peombwa mentioned this pull request Apr 11, 2022
peombwa added a commit that referenced this pull request Apr 11, 2022
* Weekly OpenApiDocs Download (#1136)

* Weekly OpenApiDocs Download. [run ci]

* Add generated MgCommandMetadata.json. [run ci]

Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com>

* Create projectsbot.yml

Adds a yaml file for adding issues to the project board

* Docs Generation (#1138)

* Weekly OpenApiDocs Download. [run ci]

* Add generated MgCommandMetadata.json. [run ci]

* Docs Generation for Devices.CloudPrint [run ci]

* Docs Generation for Devices.CorporateManagement [run ci]

* Docs Generation for DeviceManagement.Enrolment [run ci]

* Docs Generation for Users.Functions [run ci]

* Docs Generation for Files [run ci]

* Docs Generation for Identity.Governance [run ci]

* Docs Generation for CrossDeviceExperiences [run ci]

* Docs Generation for Identity.SignIns [run ci]

* Docs Generation for DirectoryObjects [run ci]

* Docs Generation for ChangeNotifications [run ci]

* Docs Generation for Bookings [run ci]

* Docs Generation for Identity.DirectoryManagement [run ci]

* Docs Generation for Education [run ci]

* Docs Generation for Users [run ci]

* Docs Generation for Sites [run ci]

* Docs Generation for Users.Actions [run ci]

* Docs Generation for DeviceManagement [run ci]

* Docs Generation for Teams [run ci]

* Docs Generation for Security [run ci]

* Docs Generation for Groups [run ci]

Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com>
Co-authored-by: Peter Ombwa <peombwa@microsoft.com>

* Weekly OpenApiDocs Download (#1151)

* Weekly OpenApiDocs Download. [run ci]

* Add generated MgCommandMetadata.json. [run ci]

Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com>

* Docs Generation (#1152)

* Weekly OpenApiDocs Download. [run ci]

* Add generated MgCommandMetadata.json. [run ci]

* Docs Generation for DeviceManagement.Functions [run ci]

* Docs Generation for Identity.SignIns [run ci]

* Docs Generation for Education [run ci]

* Docs Generation for Devices.CloudPrint [run ci]

* Docs Generation for Compliance [run ci]

* Docs Generation for Users.Functions [run ci]

* Docs Generation for Devices.CorporateManagement [run ci]

* Docs Generation for Files [run ci]

* Docs Generation for Groups [run ci]

* Docs Generation for Users.Actions [run ci]

* Docs Generation for Identity.Governance [run ci]

* Docs Generation for Security [run ci]

* Docs Generation for ChangeNotifications [run ci]

* Docs Generation for DeviceManagement.Enrolment [run ci]

* Docs Generation for DeviceManagement.Actions [run ci]

* Docs Generation for Sites [run ci]

* Docs Generation for Applications [run ci]

* Docs Generation for Users [run ci]

Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com>
Co-authored-by: Peter Ombwa <peombwa@microsoft.com>

* Chnage build agent. (#1157)

* Weekly OpenApiDocs Download (#1170)

* Weekly OpenApiDocs Download. [run ci]

* Add generated MgCommandMetadata.json. [run ci]

Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com>

* Update Get-MgApplication.md (#1160)

Examples 4 and 5 had users in the description. Corrected that to applications.

Co-authored-by: Peter Ombwa <peombwa@microsoft.com>

* Docs Generation (#1172)

* Weekly OpenApiDocs Download. [run ci]

* Add generated MgCommandMetadata.json. [run ci]

* Docs Generation for CloudCommunications [run ci]

* Docs Generation for Files [run ci]

* Docs Generation for Users.Actions [run ci]

* Docs Generation for Identity.DirectoryManagement [run ci]

* Docs Generation for Devices.CorporateManagement [run ci]

* Docs Generation for DeviceManagement.Functions [run ci]

* Docs Generation for Identity.SignIns [run ci]

* Docs Generation for Reports [run ci]

* Docs Generation for DeviceManagement.Administration [run ci]

* Docs Generation for Sites [run ci]

* Docs Generation for Education [run ci]

* Docs Generation for Users.Functions [run ci]

* Docs Generation for DeviceManagement [run ci]

* Docs Generation for Identity.Governance [run ci]

* Docs Generation for Applications [run ci]

* Docs Generation for Groups [run ci]

* Docs Generation for Users [run ci]

* Docs Generation for Teams [run ci]

Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com>
Co-authored-by: Peter Ombwa <peombwa@microsoft.com>

* Weekly OpenApiDocs Download (#1180)

* Weekly OpenApiDocs Download. [run ci]

* Add generated MgCommandMetadata.json. [run ci]

Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com>

* Docs Generation (#1181)

* Weekly OpenApiDocs Download. [run ci]

* Add generated MgCommandMetadata.json. [run ci]

* Docs Generation for Identity.DirectoryManagement [run ci]

* Docs Generation for Teams [run ci]

* Docs Generation for Applications [run ci]

* Docs Generation for Devices.CorporateManagement [run ci]

* Docs Generation for Compliance [run ci]

* Docs Generation for Files [run ci]

* Docs Generation for Identity.SignIns [run ci]

* Docs Generation for Sites [run ci]

* Docs Generation for Groups [run ci]

* Docs Generation for Search [run ci]

* Docs Generation for Users.Functions [run ci]

* Docs Generation for Users.Actions [run ci]

* Docs Generation for Education [run ci]

* Docs Generation for Identity.Governance [run ci]

* Docs Generation for Users [run ci]

* Docs Generation for DeviceManagement [run ci]

* Docs Generation for Security [run ci]

* Docs Generation for Devices.CloudPrint [run ci]

Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com>
Co-authored-by: Peter Ombwa <peombwa@microsoft.com>

* Enable Test-MgGroupDynamicMembershipRule command. (#1142)

* supress Invoke-MgFilterEntitlementManagementCatalogAccessPackage (#1190)

Co-authored-by: Peter Ombwa <peombwa@microsoft.com>

* add to beta profile (#1189)

Co-authored-by: Peter Ombwa <peombwa@microsoft.com>

* Fixes Missing `-Debug` Request Body in PS 5.1 (#1179)

* Fall back to OnBeforeCall in PS 5.1.

* Add Pester tests.

* Use PSHostVersion to detect PS edition.

* Reuse session HTTP client. (#1184)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com>
Co-authored-by: DeVere Dyett <ddyett@microsoft.com>
Co-authored-by: K N Manoj Reddy <44399320+ManojReddy-MSFT@users.noreply.github.com>
Co-authored-by: Mark Wahl <mwahl@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants