Get-MgReport* cmdlets with a -Period parameter should be constrained

[mmascolino]

Most of the reporting cmdlets like Get-MgReportOffice365ActiveUserDetail support a parameter called -Period which is defined as being 'D7',' D30','D90', or 'D180'. In the PowerShell this manifest as a generic [string] parameter. I think this should be a type that is constrained/validated to the 4 strings that are actually acceptable.

[peombwa]

Thanks for following up on this.

Unfortunately, the API schema describes period parameter as string type with no hint of what the valid values are. This makes it impossible to know what valid values are supported at generation time. We use the CSDL API schema as our sole source of truth when generating the commands:

<Function Name="getOffice365ActiveUserDetail" IsBound="true" IsComposable="true">
  <Parameter Name="bindingParameter" Type="graph.reportRoot" />
  <Parameter Name="period" Type="Edm.String" Nullable="false" Unicode="false" />
  <ReturnType Type="Edm.Stream" Nullable="false" />
</Function>

The API should ideally declare period as an Enum type since it has a fixed number of supported values.

I'll keep the issue open as a feature request for us to consider in future versions of the module.

[peombwa]

Update on the issue. We can consider adding an argument completer for -Preiod on commands in the Reports module. The argument completer should allow customers to tab through the values when entering the parameter interactively.

The feature will exclusively ship available in v2 due to code generator support.

[peombwa]

Fixed by #1956. Feature will ship in v2.0.0-preview9.