Remove phpDocumentor from composer.json - unblock SDK generation #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zengin
requested review from
MIchaelMainer,
baywet,
ddyett and
nikithauc
as code owners
ddyett
approved these changes
Feb 18, 2021
Contributor
Author
|
@MIchaelMainer, tagging you in this PR in case you have any concerns with the change when you come back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we upgraded to php8.0, phpDocumentor started to fail in
composer installstep.According to phpDocumentor documentation, installing the package via composer is not recommended:
https://github.com/phpDocumentor/phpDocumentor#via-composer-not-recommended
Another data point is that the last update to our docs are from 4 years ago. So we don't need phpDocumentor in
require-devcategory at least in the foreseeable future. There are other ways to run the doc generator if we decide to do so.Fixes microsoftgraph/MSGraph-SDK-Code-Generator#453 and unblocks SDK generation for PHP.
Successful generation run: https://microsoftgraph.visualstudio.com/Graph%20Developer%20Experiences/_build/results?buildId=40880&view=results