Return empty array on empty collection response

[guilliamxavier]

Fixes #46
Closes #105

[msftclas]

All CLA requirements met.

[guilliamxavier]

(I have added 2 extra commits I think make the code better, but they're optional, feel free to discard them)

[MIchaelMainer]

Thank you @guilliamxavier . I'm going to run this tomorrow. I'll be bumping the version to 2.0.0 as it is possible that people have taken a dependency on the old behavior.

[guilliamxavier]

Thank you for responding. As concerns a hypothetical dependency on the buggy behavior... given for example

$query = http_build_query(['$filter' => $filter, '$orderby' => $orderby]);
$userGrabber = $graph->createCollectionRequest('GET', "/users?$query")
                     ->setReturnType(Model\User::class)
                     ->setPageSize(100);
$users = $userGrabber->getPage();

I admit that (although very unlikely) there is indeed a slight possibility that someone might have written some "fragile" code like

// this code assumes that $users cannot be empty:
if (is_array($users)) {
    /* code that must be run if the real collection was not empty (use $users) */
} else {
    /* code that must be run if the real collection was empty (don't use $users) */
}

and would need to change it (actually, to fix it), but there's a much higher probability that people have written reasonable code like

// this code trusts that $users is an array:
if (count($users) > 0) {
    /* code that must be run if the real collection was not empty (use $users) */
} else {
    /* code that must be run if the real collection was empty (don't use $users) */
}

then if got bitten by the bug (e.g. "expected array, got object"), adapted it like this:

// this code checks to be sure that $users is an array:
if (is_array($users) && count($users) > 0) {
    /* code that WILL be run if the real collection was not empty (use $users) */
} else {
    /* code that WILL be run if the real collection was empty (don't use $users) */
}

or (that's me) like that:

// Workaround for bug https://github.com/microsoftgraph/msgraph-sdk-php/issues/46
if (!is_array($users)) {
    $users = [];
}

// this code can now be confident that $users is an array:
if (count($users) > 0) {
    /* code that WILL be run if the real collection was not empty (use $users) */
} else {
    /* code that WILL be run if the real collection was empty (don't use $users) */
}

For me it would be a bit sad if people who are using version ^1.0 / 1.* would not get the bugfix (until --if ever-- they do a major version upgrade to ^2.0 / 2.*) because of an unknown [small] number of "sloppy" coders... But if you have a very strict BC policy (even for bugs), I guess that's how it is... Anyhow thank you for considering 🙂

[MIchaelMainer]

Thank you @guilliamxavier for your time on this. And FYI, I'm going to be updating PHP to 7.4 as well as updating the dependencies.

[guilliamxavier]

I see that this was released in 1.13.0 (with a bump to PHP 7.1) 🎉 Thanks