Skip to content

Conversation

@SilasKenneth
Copy link
Member

@SilasKenneth SilasKenneth commented May 22, 2024

Microsoft Reviewers: Open in CodeFlow

@SilasKenneth SilasKenneth self-assigned this May 22, 2024
@SilasKenneth SilasKenneth requested a review from a team May 22, 2024 10:00
@SilasKenneth SilasKenneth changed the base branch from dev to main May 22, 2024 10:00
@baywet baywet linked an issue May 22, 2024 that may be closed by this pull request
9 tasks
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this PR is still WIP, I'll switch is back to draft

@baywet baywet marked this pull request as draft May 22, 2024 12:28
baywet and others added 2 commits May 22, 2024 08:28
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
@SilasKenneth
Copy link
Member Author

I would recommend using something other than

```json

to avoid the red highlighting for comments in json
Screenshot 2024-05-22 154041


That's the reason I used json5. We can also use js. What do you think @baywet?

@baywet
Copy link
Member

baywet commented May 22, 2024

@SilasKenneth have you tried jsonc (json with comments) ? I don't have a strong opinion either way. I didn't know json5 was a thing until your last message, sorry for creating confusion here. https://json-5.com/json-vs-json5

@SilasKenneth
Copy link
Member Author

@SilasKenneth have you tried jsonc (json with comments) ? I don't have a strong opinion either way. I didn't know json5 was a thing until your last message, sorry for creating confusion here. https://json-5.com/json-vs-json5

I just tried it now. Looks like it achieves the desired output too.

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready to merge, thanks for making the changes!

@baywet baywet marked this pull request as ready for review May 24, 2024 12:04
@SilasKenneth SilasKenneth enabled auto-merge May 24, 2024 12:05
@SilasKenneth SilasKenneth merged commit bd17894 into main May 24, 2024
@SilasKenneth SilasKenneth deleted the chore/release-please-config branch May 24, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add release please configuration

3 participants