Skip to content

chore: update branch protection rules #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Ndiritu merged 3 commits into from
Sep 1, 2023
Merged

chore: update branch protection rules #1333

Ndiritu merged 3 commits into from
Sep 1, 2023

Conversation

@MIchaelMainer
Copy link
Collaborator

@MIchaelMainer MIchaelMainer commented Aug 30, 2023 •
edited
Loading

  • Require status checks to pass before merging
  • Require code owner approvals of all changes in main/master and dev branches

Note: We must validate this PR after merge by opening another PR to make sure that the required status checks run as expected so that we don't introduce misconfigured blocking policy.

@MIchaelMainer
chore: update branch protection rules
55c3706 
* Require status checks to pass before merging
* Require code owner approvals of all changes in main/master and dev branches
@MIchaelMainer MIchaelMainer requested a review from a team August 30, 2023 19:48
Ndiritu
Ndiritu reviewed Aug 31, 2023
View reviewed changes
@Ndiritu Ndiritu merged commit 4dfaed1 into dev Sep 1, 2023
@Ndiritu Ndiritu deleted the mmainer/updatepolicy branch September 1, 2023 05:47
@MIchaelMainer MIchaelMainer mentioned this pull request Sep 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Ndiritu Ndiritu Ndiritu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MIchaelMainer @Ndiritu