Add page iterator support. #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilasKenneth
requested review from
MIchaelMainer,
Ndiritu,
ddyett,
nikithauc,
shemogumbe and
zengin
as code owners
SilasKenneth
changed the title
Ndiritu
suggested changes
Sep 6, 2022
There was a problem hiding this comment.
Must a dev have models for them to use the Page Iterator?
We seem to handle the case that a Page Iterator is initialised with a response object as an associative array, meaning the callback provided should accept an array representing a single object. However, after the next page is retrieved, the request adapter will have deserialized the objects in the value property.
Ndiritu
reviewed
Sep 7, 2022
Ndiritu
reviewed
Sep 7, 2022
Ndiritu
reviewed
Sep 7, 2022
Ndiritu
reviewed
Sep 7, 2022
Co-authored-by: Philip Gichuhi <pgichuhi@microsoft.com>
Co-authored-by: Philip Gichuhi <pgichuhi@microsoft.com>
Ndiritu
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.