-
Couldn't load subscription status.
- Fork 17
Recursively convert MSObject to NSDictionary when serializing MSObject #36
base: master
Are you sure you want to change the base?
Conversation
…serializing MSObject
|
I also stumbled on this, but also fixed enum types thanks to the fix of @tobihagemann. He may first merges my branch: https://github.com/tritter/msgraph-sdk-objc-models |
Cherry-picked from: tritter@d1ead2e tritter@c359bc9 tritter@c94d2b4
|
@tritter Done! Cherry-picked from your commits because I didn't want to merge unnecessary changes from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works for me
|
Recursively convert to NSDictionary is missed - MS really? It looks like that should be released ASAP in the 1.3.1 version. |
|
@tobihagemann Also, I guess it should be correct to update the method -(NSMutableDictionary *)getDictionary
{
return [[self recursivelyConvertObjectsToDictionariesInDictionary:self.dictionary] mutableCopy];
}because the classes which inherit |
|
I haven't thought about this PR for a while now. You could be right but I have no idea what side-effects this would have. As I've stated in the beginning:
Edit: To be more specific, |
Fixes #27
As proposed in #27 (comment), this PR enhances the
-[getSerializedDataWithError:]method inMSObjectby recursively convertingMSObjects toNSDictionary.Since I have no idea how the models are actually generated, I didn't propose a solution that would make the dictionaries serializable from the get-go.