Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated GraphRequest.ts for .count() scenario #243

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Conversation

krototype
Copy link
Contributor

Updated GraphRequest.ts to handle .count() when no parameter is specified

Summary

When the query parameter .count() didn't have any parameter passed, it used to give an error.
So adding the default value as false for this case (this is according to the graph behavior).

Closing issues

#241

Fixes #241

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Updated GraphRequest.ts to handle .count() when no parameter is specified
@krototype krototype merged commit b9a66b4 into dev Oct 25, 2019
@krototype krototype deleted the abhsriva/update-count branch October 25, 2019 05:15
@krototype krototype restored the abhsriva/update-count branch October 25, 2019 06:54
@nikithauc nikithauc deleted the abhsriva/update-count branch September 2, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default count() param to true
2 participants