Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post request with empty body, now working fine. #229

Merged
merged 5 commits into from
Oct 3, 2019

Conversation

krototype
Copy link
Contributor

@krototype krototype commented Sep 16, 2019

Summary

POST request with the empty body are possible for some situations, according to the graph. Made changes for the SDK to work for the same.

Motivation

Received an issue, where POST request with the empty body was working fine.

Closing issues

Fixes #225

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bilalgce
Copy link

Looks good to me. Please pull latest changes into this branch.

Copy link

@bilalgce bilalgce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pull latest changes from dev into this branch

@krototype krototype requested a review from bilalgce September 16, 2019 09:06
@krototype krototype closed this Sep 16, 2019
@krototype krototype reopened this Sep 17, 2019
Copy link
Contributor

@muthurathinam muthurathinam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good.

@krototype krototype merged commit 7baaf98 into dev Oct 3, 2019
@nikithauc nikithauc deleted the abhsriva/emptyPostRequest branch September 2, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Cannot read property 'constructor' of undefined' when trying to send draft email
4 participants