Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax error in README code sample #199

Merged
merged 1 commit into from
Jul 10, 2019

Conversation

KevinTCoughlin
Copy link
Contributor

@KevinTCoughlin KevinTCoughlin commented Jul 10, 2019

Summary

There's a syntax error in the MSAL configuration code sample that prevents folks from running the code when copy & pasted into their solution.

I ran into it while onboarding to the library, specifically when trying to use ImplicitMSALAuthenticationProvider.

cc: @natalieethell

Motivation

This is a minor documentation change.

Test plan

N/A

Closing issues

N/A

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@muthurathinam muthurathinam merged commit beb0d60 into microsoftgraph:dev Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants