Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug "Request" is not defined #197

Merged
merged 1 commit into from
Jul 1, 2019
Merged

Fix bug "Request" is not defined #197

merged 1 commit into from
Jul 1, 2019

Conversation

muthurathinam
Copy link
Contributor

Summary

Fixing Request not defined bug and updating dependency packages.

Motivation

  1. Request is not defined in the node environment in such cases it better to verify before acting upon, so 2. have checked for the Request object presence and used.
    To be up to date with dependency list.

Test plan

npm test will ensure the code is stable

Closing issues

#189

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • All existing tests passed.

1. Fix bug "Request" is not defined
2. Update dependencies to latest versions
@muthurathinam muthurathinam merged commit a837453 into dev Jul 1, 2019
@muthurathinam muthurathinam deleted the Bug_Fixes branch July 1, 2019 09:39
@jetersen jetersen mentioned this pull request Aug 12, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants