Better define exceptions #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MIchaelMainer
requested review from
Ndiritu,
SilasKenneth,
calebkiage,
jobala,
nikithauc,
peombwa,
samwelkanda and
shemogumbe
nikithauc
reviewed
Jul 1, 2021
content/ErrorContent.md
Outdated
| - Match the specification as defined by the Microsoft API Guidelines | ||
| - Match the specification as defined by the [Microsoft API Guidelines](https://github.com/microsoft/api-guidelines/blob/07a1e42e3e33f94df782abfcbaec24b63968c120/Guidelines.md#5-taxonomy) for errors returned in API responses. | ||
| - Service errors SHOULD be defined in a class named ServiceException or ServiceError depending on the platform. | ||
| - Client errors SHOULD be defined in a class named ClientException or ClientError depending on the platform. |
There was a problem hiding this comment.
I suggest we should mention the class names with the Graph as a prefix here -
GraphClientException
GraphServiceException
nikithauc
reviewed
Jul 1, 2021
| - Match the specification as defined by the [Microsoft API Guidelines](https://github.com/microsoft/api-guidelines/blob/07a1e42e3e33f94df782abfcbaec24b63968c120/Guidelines.md#5-taxonomy) for errors returned in API responses. | ||
| - Service errors SHOULD be defined in a class named ServiceException or ServiceError depending on the platform. | ||
| - Client errors SHOULD be defined in a class named ClientException or ClientError depending on the platform. | ||
| - Client and service errors should use common properties according to the Microsoft API Guidelines. |
There was a problem hiding this comment.
Please add the json representation of the graph service error - https://docs.microsoft.com/en-us/graph/errors#json-representation
The ServiceException should capture these properties
nikithauc
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.