Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): improve contrast ratio on component style stories #3421

Merged
merged 2 commits into from
Mar 25, 2025

Conversation

Mnickii
Copy link
Collaborator

@Mnickii Mnickii commented Mar 24, 2025

Closes #3370
Closes #3372

PR Type

Bugfix

Description of the changes

Corrects contrast ratio in elements

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Testing

  1. Open Desktop Accessibility Insights.
  2. Go through the provided link and ensure the mgt-planner custom css properties story and mgt-person More Examples story have the required contrast ratios between the previously flagged elements.

@ElinorW
Copy link
Contributor

ElinorW commented Mar 24, 2025

Hey,
still getting a color contrast issue on the planner component
image

Copy link

📖 The updated storybook is available here

@github-project-automation github-project-automation bot moved this to Done ✔️ in Graph Toolkit Mar 24, 2025
@Mnickii Mnickii merged commit b69872a into main Mar 25, 2025
12 checks passed
@Mnickii Mnickii deleted the fix/a11y-3370 branch March 25, 2025 07:49
@github-project-automation github-project-automation bot moved this from Done ✔️ to Shipped 🚀 in Graph Toolkit Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment