Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): improve keyboard accessibility in mgt-teams-channel-picker #3419

Merged
merged 3 commits into from
Mar 25, 2025

Conversation

Mnickii
Copy link
Collaborator

@Mnickii Mnickii commented Mar 24, 2025

Closes #3383
Closes #3380

PR Type

Bugfix

Description of the changes

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

Testing

On the provided links, with narrator open, test that the picker buttons are announced correctly and that keyboard focus does not appear twice on the up and down chevrons.

@github-project-automation github-project-automation bot moved this to Done ✔️ in Graph Toolkit Mar 24, 2025
Copy link

📖 The updated storybook is available here

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@Mnickii Mnickii merged commit c796563 into main Mar 25, 2025
11 of 12 checks passed
@Mnickii Mnickii deleted the fix/a11y-3383 branch March 25, 2025 08:03
@github-project-automation github-project-automation bot moved this from Done ✔️ to Shipped 🚀 in Graph Toolkit Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Shipped 🚀
2 participants