Skip to content

Conversation

@millicentachieng
Copy link
Contributor

Merge hotfix #949 into dev

millicentachieng and others added 2 commits May 14, 2021 09:11
Co-authored-by: Millicent Achieng <miachien@microsoft.com>
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-952.centralus.azurestaticapps.net

Copy link
Contributor

@jobala jobala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This defaults to 'GET' for something like 'POST' when the user wanted to make a POST request. Why are we defaulting to GET instead of letting the user know that the method is invalid? What do you think of showing the user an error message ?

@thewahome
Copy link
Collaborator

thewahome commented May 19, 2021

This is based on the link that is placed in the docs that redirects to GE when clicked. It makes sense to default to GET when no method is passed in that URL. There is no opportunity for us to give feedback to the writer of the docs team at this point

@millicentachieng millicentachieng merged commit c0fd88b into dev May 19, 2021
@millicentachieng millicentachieng deleted the merge-v4.6.1 branch May 19, 2021 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Graph Explorer crashes if 'request' query parameter is specified in URL but not 'method'

4 participants