Skip to content

Conversation

@thewahome
Copy link
Collaborator

Overview

When typing in /me/photo/$value, $value was not showing up in the list of suggestions provided.

Notes

Previously, adding a $ appended suggestion would trigger the = sign to show properties. This fix isolates the = sign addition to the context of the url. This now makes it possible to have $ sign paths appear as suggestions e.g $count, $value etc

Testing Instructions

  • Write me/photo/
  • Notice $value in the list of items

@thewahome thewahome requested a review from a team as a code owner March 15, 2024 10:23
@thewahome thewahome linked an issue Mar 19, 2024 that may be closed by this pull request
@thewahome thewahome merged commit 151f34a into dev Mar 25, 2024
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

ElinorW added a commit that referenced this pull request Mar 27, 2024
* Chore(deps): Bump follow-redirects from 1.15.0 to 1.15.6 (#3058)

* Fix: Resource path causing app to crash (#3053)

* Fix: [autocomplete] show dollar sign paths (#3052)

* Fix: Canary urls crashing (#3062)

* Bump version to 9.8.0
@thewahome thewahome deleted the fix/autocomplete-show-dollar-sign-paths branch August 19, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GE showing error messages for sample queries.

3 participants