-
Notifications
You must be signed in to change notification settings - Fork 27
Enganga/update entra invited user sponsors from invited by #1354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Enganga/update entra invited user sponsors from invited by #1354
Conversation
Learn Build status updates of commit 37c20b5: ✅ Validation status: passedFor more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 26fa4c5: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 587c088: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit fceecd5: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit b8a5e9e: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 789ea81: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
789ea81
to
c9d49d6
Compare
Learn Build status updates of commit c9d49d6: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit af0ab89: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit f77f57b: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit e616c7e: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
e616c7e
to
a6a6587
Compare
Learn Build status updates of commit a6a6587: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit b8db6c5: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 61194f2: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit d043f9e: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
…d' value and hence we don't the inline function. Updated tests
Learn Build status updates of commit 564adae: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
…andPrerequisite.ps1
Learn Build status updates of commit 79e3157: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit c624de3: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 33627e4: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The design for this cmdlet is messy
- Get users and expand sponsors
- Use the user id to invoke /users/id/invitedBy
This is duplication. The first request also returns the sponsor, then the second request gets the sponsor using an API request.
This design should be either
Get-EntraUser
and selectUserId
only.- Call
/Users/<Id>/sponsors
end point to return the sponsors.
or
Get-MgUser
withExpandProperty
. Get the value of the sponsors from the response
Note:
For v1.0, endpoint is /Users/<Id>/sponsors
For beta, endpoint can either be /Users/<Id>/sponsors
or /Users/<Id>/invitedBy
...le/EntraBeta/Microsoft.Entra.Beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.ps1
Outdated
Show resolved
Hide resolved
Also we could run one API call Then pick the sponsors array and craft a response |
Learn Build status updates of commit 9c667ee: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 2fff099: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 7ae84d4: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit dd7c32f: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit d757cd7: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 2220b91: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
…hell into enganga/Update-EntraInvitedUserSponsorsFromInvitedBy
Learn Build status updates of commit 330a446: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Porting of Update-MsIdInvitedUserSponsporsFromInvitedBy for both GA and Beta