Serialize stream properties in PHP models #867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ndiritu
requested review from
MIchaelMainer,
SilasKenneth,
andrueastman,
baywet,
ddyett,
nikithauc,
ramsessanchez,
rkodev and
zengin
as code owners
andrueastman
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Stream properties in models were NOT previously being serialized into the request payload.
This fix casts the streams to "string" which rewinds the stream & reads the stream's contents into a string
Generated code differences
https://github.com/microsoftgraph/msgraph-sdk-php/pull/1055/files
https://github.com/microsoftgraph/msgraph-sdk-php/pull/1056/files
Links to issues or work items this PR addresses
closes microsoftgraph/msgraph-sdk-php#1052
Microsoft Reviewers: Open in CodeFlow