Skip to content

Fix null reference exception when method return type is an odata primitive. #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrueastman merged 2 commits into from
Oct 25, 2022
Merged

Fix null reference exception when method return type is an odata primitive. #854

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d88cedb
Fix for method returning odata primitive
Oct 24, 2022
82f7106
Default to empty list.
Oct 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/GraphODataTemplateWriter/Extensions/OdcmModelExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,10 +730,10 @@ public static List<OdcmProperty> GetComposableFunctionReturnTypeNavigations(this
throw new InvalidOperationException("This extension method is intended " +
"to only be called on a composable function.");

return (odcmMethod.ReturnType as OdcmClass).Properties
return (odcmMethod.ReturnType as OdcmClass)?.Properties
.Where(p => p.IsLink)
.OrderBy(p => p.Name)
.ToList();
.ToList() ?? new List<OdcmProperty>(); // default to empty list
}

/// <summary>
Expand Down