Use CreateFile2 and CreateFileMapping#536
Merged
Merged
Conversation
micahl
requested review from
BenJKuhn,
DefaultRyan,
Scottj1s and
kennykerr
as code owners
Member
oh, that's good to know. ok, leave as is, but please add some error handling (see https://github.com/microsoft/xlang/blob/d2cff46d73a2b5f320f8a101e0c39413f069d849/src/platform/win32_string_convert.cpp). |
kennykerr
reviewed
Jul 24, 2019
kennykerr
reviewed
Jul 24, 2019
kennykerr
reviewed
Jul 24, 2019
Scottj1s
approved these changes
Jul 24, 2019
Member
|
thanks Micah |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.