run spinxsk on multiple interfaces - #965
Draft
Michael Friesen (mtfriesen) wants to merge 17 commits into
Draft
Michael Friesen (mtfriesen) wants to merge 17 commits into
Michael Friesen (mtfriesen) wants to merge 17 commits into
Conversation
This reverts commit 642b1c0.
Michael Friesen (mtfriesen)
marked this pull request as ready for review
April 15, 2026 11:54
Michael Friesen (mtfriesen)
marked this pull request as draft
April 15, 2026 20:36
Michael Friesen (mtfriesen)
added a commit
that referenced
this pull request
Jul 22, 2026
…setup The socket-setup success-rate breakdown shows setups collapsing at the final bind/activate steps (Prerelease x64: bind 19%, activate 8%; WS2022: bind 30%, activate 20%) while init/umem/rx/tx are healthy. A setup counts as successful only if the socket is fully configured within a 500ms window (completeEvent in QueueWorkerFn). FuzzSocketMisc could issue a blocking XskNotifySocket with a WAIT flag and a timeout of up to 1000ms on the same fuzzer thread doing the configuration, consuming the entire window and preventing bind/activate from completing. Cap the fuzzed notify timeout to <3ms (matching PR #965's mitigation) so setup can progress.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the purpose of and changes within this Pull Request.
To try to increase our repro rate of interesting spinxsk bugs, increase the parallelism of our tests by spinning on multiple NICs. This requires adding support for multiple XDPMP instances, and also adds some incidental improvements to driver cleanup logic after the machine is in a dirty state post-reboot.
If this shows promise, we can try refactoring FNMP to support the same thing.
Testing
Do any existing tests cover this change? Are new tests needed?
Yes.
Documentation
Is there any documentation impact for this change?
No.
Installation
Is there any installer impact for this change?
No.