Update catalog handling #385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pnpm treats
catalog:andcatalog:defaultas both pointing to a catalog named "default", which can be defined under eithercatalog:orcatalogs: default:.yarn treats
catalog:default(catalogs: default:) as a separate named catalog from the default one, and the actual default catalog must be defined undercatalog:.Update the utilities to handle this... The approach I went with is that for pnpm and midgard-yarn, if a named catalog "default" exists in the yaml, it's translated to
Catalogs.default(pnpm errors on install if both are defined). Regular yarn has no special handling.Also add a utility
catalogsToYaml, mainly for use in tests.