Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camunda.Modeler version 5.7.0 #95988

Merged
merged 3 commits into from
Feb 20, 2023
Merged

Camunda.Modeler version 5.7.0 #95988

merged 3 commits into from
Feb 20, 2023

Conversation

Miladiir
Copy link
Contributor

@Miladiir Miladiir commented Feb 9, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Miladiir
Copy link
Contributor Author

Miladiir commented Feb 9, 2023

@microsoft-github-policy-service agree

@Miladiir Miladiir mentioned this pull request Feb 9, 2023
5 tasks
@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Feb 9, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @wingetbot,

During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI, or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect them and the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

Template: msftbot/validationError/installation/unattended

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. Needs-Author-Feedback This needs a response from the author. labels Feb 9, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Miladiir
Copy link
Contributor Author

Miladiir commented Feb 9, 2023

This is a portable GUI App. Unfortunately I cannot get this to work. Adding the PortableCommandAlias: camunda-modeler does not work, The unzipped folder is added to path and I can start the application by typing "Camunda Modeler" into the windows run (WIN+R) prompt, but not from pwsh or cmd. Of course, the app also does not show in WIN+S or Start Menu.

Where to go from here? I noticed that the other zipped programs seem to be command line only. Is it not supported yet?

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Feb 9, 2023
@microsoft-github-policy-service
Copy link
Contributor

wingetbot,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@Trenly
Copy link
Contributor

Trenly commented Feb 10, 2023

This is blocked by microsoft/winget-cli#2711; As a workaround, start 'camunda modeler' does seem to launch the program.

Start menu entries and desktop icons are not added for portable packages, which is intentional.

@Miladiir
Copy link
Contributor Author

@Trenly thanks, that works. Do we want to merge this still, or wait for winget to support this use case first? I am willing to contribute for this package in the future.

@mdanish-kh
Copy link
Contributor

@Trenly thanks, that works. Do we want to merge this still, or wait for winget to support this use case first? I am willing to contribute for this package in the future.

If it does not launch as expected, merging it would mean a bad user experience.
cc @denelon - Maybe we can have something like a .dll label if we're blocking these submissions?

@Trenly
Copy link
Contributor

Trenly commented Feb 13, 2023

There should be a Zip-Binary label already existing

@denelon
Copy link
Contributor

denelon commented Feb 13, 2023

I added:
"Depends on .dlls that aren't available via symlink" to the description of the "zip-binary" label. If it should be worded differently, just let me know. 😊

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Feb 14, 2023
@mdanish-kh
Copy link
Contributor

I added: "Depends on .dlls that aren't available via symlink" to the description of the "zip-binary" label. If it should be worded differently, just let me know. 😊

We would probably also need that label in winget-pkgs repo and the ability to tag issues and PRs with it through fabricbot 👀

@Trenly
Copy link
Contributor

Trenly commented Feb 15, 2023

I added: "Depends on .dlls that aren't available via symlink" to the description of the "zip-binary" label. If it should be worded differently, just let me know. 😊

We would probably also need that label in winget-pkgs repo and the ability to tag issues and PRs with it through fabricbot 👀

Yes; I think the team is still working through FabricBot issues and are looking for it to be a bit more stable before additional updates

@denelon
Copy link
Contributor

denelon commented Feb 15, 2023

I created the label so we can use it as soon as we're ready.

https://github.com/microsoft/winget-pkgs/labels?q=zip-binary

@denelon denelon linked an issue Feb 17, 2023 that may be closed by this pull request
5 tasks
….yaml


Adds PublisherUrl from suggestion.

Co-authored-by: Stephen Gillie <114952565+stephengillie@users.noreply.github.com>
auto-merge was automatically disabled February 19, 2023 10:42

Head branch was pushed to by a user without write access

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Comment was made before the most recent commit for PR 95988 in repo microsoft/winget-pkgs

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Completed Validation passed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. labels Feb 19, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Feb 19, 2023
@microsoft-github-policy-service
Copy link
Contributor

wingetbot,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit fa522d4 into microsoft:master Feb 20, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Feb 20, 2023
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@Miladiir Miladiir deleted the autogenerated/Camunda.Modeler/611501af-3bf6-402e-9639-950a9d367211 branch February 20, 2023 22:11
@Trenly Trenly mentioned this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Package Request]: Camunda Modeler
7 participants