Skip to content

Revert InstallerSwitches: Romanitho.Winget-AutoUpdate version 2.12.0 - #401375

Merged
microsoft-github-policy-service[bot] merged 1 commit into
microsoft:masterfrom
DandelionSprout:wau-u
Jul 12, 2026
Merged

Revert InstallerSwitches: Romanitho.Winget-AutoUpdate version 2.12.0#401375
microsoft-github-policy-service[bot] merged 1 commit into
microsoft:masterfrom
DandelionSprout:wau-u

Conversation

@DandelionSprout

@DandelionSprout Imre Eilertsen (DandelionSprout) commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

📖 Description

Turned out the InstallerSwitches I added a couple hours ago were in fact disadvantageous, in an "I acted in good faith but I ultimately bungled it big regardless of circumstances" blunder of mine.

In particular, I learned only 10 minutes ago that Task Scheduler had subfolders. I was prior to that point of the belief that all tasks were in one list.

✅ Checklist

📦 Manifest Checklist

  • Checked that there aren't other open pull requests for the same manifest update/change
  • This PR only modifies one (1) manifest
  • Validated manifest locally with winget validate --manifest <path> (validation guide)
  • Tested manifest locally with winget install --manifest <path>
  • Manifest conforms to the 1.12 schema

Note: <path> is the directory containing the manifest you're submitting.

@wingetbot

Copy link
Copy Markdown
Collaborator

Validation Pipeline Run WinGetSvc-Validation-146-401375-20260712-1

@KnifMelti

Copy link
Copy Markdown
Contributor

#401303 (comment)

@DandelionSprout

Imre Eilertsen (DandelionSprout) commented Jul 12, 2026

Copy link
Copy Markdown
Contributor Author

Okay, sure enough. I'll try, even if there's not all that much to ask him about at the time of writing that I can come up with.

———————————————

Romain (@Romanitho) Though the situation has been mostly solved by now (At least when this PR gets merged, which hopefully occurs within 1½-3 hours since it's a simple maintenance PR), can you confirm first-hand whether or not the Romanitho.Winget-AutoUpdate package is intended to not use any of the installer switches listed in https://github.com/Romanitho/Winget-AutoUpdate/blob/main/README.md ?

The context, long story short: I was unaware of the existence of Task Scheduler subfolders → Thought the Winget package did not add schedulers by default → Added /qn UPDATESINTERVAL=Daily UPDATESATLOGIN=1 as InstallerSwitches to the Winget package → Turned out it wasn't needed and that it was potentially disadvantageous depending on end-users' configs → Created this PR to remove the switches.

@wingetbot wingetbot (wingetbot) added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jul 12, 2026
@microsoft-github-policy-service
microsoft-github-policy-service Bot enabled auto-merge (squash) July 12, 2026 11:49
@stephengillie Stephen Gillie (stephengillie) added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jul 12, 2026
@microsoft-github-policy-service
microsoft-github-policy-service Bot merged commit ecdd8c2 into microsoft:master Jul 12, 2026
1 check passed
@wingetbot

Copy link
Copy Markdown
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants