New version: seerge.g-helper version 0.239#336279
New version: seerge.g-helper version 0.239#336279Stensel8 wants to merge 1 commit intomicrosoft:masterfrom
Conversation
|
Validation Pipeline Run WinGetSvc-Validation-130-336279-20260203-1 |
There was a problem hiding this comment.
Pull request overview
Adds WinGet manifests for seerge.g-helper v0.239.
Changes:
- Added the version manifest for 0.239.
- Added the default locale metadata (en-US), including release notes and URLs.
- Added the installer manifest targeting the v0.239 GitHub release and SHA256.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| manifests/s/seerge/g-helper/0.239/seerge.g-helper.yaml | Introduces the v0.239 version manifest tying the set together. |
| manifests/s/seerge/g-helper/0.239/seerge.g-helper.locale.en-US.yaml | Provides package metadata and release notes for v0.239. |
| manifests/s/seerge/g-helper/0.239/seerge.g-helper.installer.yaml | Defines the portable installer URL/SHA256 and dependency for v0.239. |
| PackageName: g-helper | ||
| PackageUrl: https://github.com/seerge/g-helper | ||
| License: GPL-3.0 | ||
| LicenseUrl: https://github.com/seerge/g-helper/blob/HEAD/LICENSE |
There was a problem hiding this comment.
LicenseUrl points to blob/HEAD/LICENSE, which is not version-specific. The manifest schema guidance recommends linking the license file to the exact package version (e.g., a tag/commit for v0.239) because licenses can change over time.
| LicenseUrl: https://github.com/seerge/g-helper/blob/HEAD/LICENSE | |
| LicenseUrl: https://github.com/seerge/g-helper/blob/v0.239/LICENSE |
| NestedInstallerFiles: | ||
| - RelativeFilePath: GHelper.exe | ||
| PortableCommandAlias: GHelper |
There was a problem hiding this comment.
PortableCommandAlias is specified under NestedInstallerFiles, but NestedInstallerType is not set. Per the manifest schema docs, PortableCommandAlias is only valid when NestedInstallerType is portable (and nested installers are intended for archive installer types like .zip). As written, the alias may be ignored by clients/validation tooling. Consider either (1) removing NestedInstallerFiles and relying on the portable executable name/Commands, or (2) if the download is actually an archive, set InstallerType to the archive type and add NestedInstallerType: portable.
| NestedInstallerFiles: | |
| - RelativeFilePath: GHelper.exe | |
| PortableCommandAlias: GHelper |
|
Found duplicate pull request(s)
|
|
Ah, my bad. Removed the duplicate. |
Checklist for Pull Requests
Manifests
winget validate --manifest <path>?winget install --manifest <path>? - No, because that will probably break my existing Zephyrus G16 configs.Note:
<path>is the directory's name containing the manifest you're submitting.Microsoft Reviewers: Open in CodeFlow