-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: Bloodstrike.pc version 1.1 #175770
base: master
Are you sure you want to change the base?
New package: Bloodstrike.pc version 1.1 #175770
Conversation
/AzurePipelines run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @FatalS3C,
The PackageIdentifier
suggestions are very optional and your feedback with these is welcome. Other than these metadata changes, the PR appears ready to merge.
PackageName: Blood Strike | ||
License: Netease | ||
Copyright: (C) Netease 保留所有权利。 | ||
ShortDescription: Blood Strike permite que você junte-se a amigos rapidamente nos modos em equipe. Encontrar seus colegas, adicioná-los ao esquadrão e iniciar uma partida é superfácil. Blood Strike foi criado para dispositivos mobile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update this so that the text's language matches the locale file's language.
# Created using wingetcreate 1.6.5.0 | ||
# yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.6.0.schema.json | ||
|
||
PackageIdentifier: Bloodstrike.pc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PackageIdentifier: Bloodstrike.pc | |
PackageIdentifier: NetEase.BloodStrike |
- The game seems to capitalize and separate the second word in the name
Blood Strike
, so thePackageIdentifier
should have this capitalized too. - Since
NetEase Games
is the developer, should this be added to thePackageIdentifier
? If not, then the currentPackageIdentifier
is okay. - Please remember to modify the file name and path to reflect any changes to the
PackageIdentifier
.
# Created using wingetcreate 1.6.5.0 | ||
# yaml-language-server: $schema=https://aka.ms/winget-manifest.defaultLocale.1.6.0.schema.json | ||
|
||
PackageIdentifier: Bloodstrike.pc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PackageIdentifier: Bloodstrike.pc | |
PackageIdentifier: NetEase.BloodStrike |
- Please update this file's contents, name, and path with any changes to the
PackageIdentifier
above.
# Created using wingetcreate 1.6.5.0 | ||
# yaml-language-server: $schema=https://aka.ms/winget-manifest.version.1.6.0.schema.json | ||
|
||
PackageIdentifier: Bloodstrike.pc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PackageIdentifier: Bloodstrike.pc | |
PackageIdentifier: NetEase.BloodStrike |
- Please update this file's contents, name, and path with any changes to the
PackageIdentifier
above.
PackageLocale: en-US | ||
Publisher: Netease | ||
PackageName: Blood Strike | ||
License: Netease |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
License: Netease | |
PackageUrl: https://www.blood-strike.com/ | |
License: Netease |
@FatalS3C please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Hello @FatalS3C, The package manager bot determined changes have been requested to your PR. Template: msftbot/changesRequested |
Checklist for Pull Requests
Manifests
winget validate --manifest <path>
?winget install --manifest <path>
?Note:
<path>
is the directory's name containing the manifest you're submitting.Microsoft Reviewers: Open in CodeFlow