Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: Nvidia.GRID version 538.46 #166661

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

jbne
Copy link
Contributor

@jbne jbne commented Aug 7, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

Resolve #166666

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Aug 7, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Aug 7, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

(Automated response - build 887.)

@Dragon1573
Copy link
Contributor

Tip

Adding Resolve #166666 to the very first comment of this PR will link this with that issue. When PR is successfully merged, the issue will also be automatically closed.

CC @jbne

@stephengillie stephengillie added Validation-Completed Validation passed and removed Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. Needs-Author-Feedback This needs a response from the author. labels Aug 9, 2024
@stephengillie
Copy link
Collaborator

Manual Validation ended with:
image

Hi @jbne,

Is another installer switch needed to verify where these files will be saved?

@stephengillie
Copy link
Collaborator

stephengillie commented Aug 14, 2024

Automatic Validation ended with:

Installation failed with exit code -1978334957
2024-08-13 09:21:04.045 [CLI ] ShellExecute installer failed: 3858759936

Automated error analysis suggests -1978334957 may mean Package not supported by the system.

(Automated response - build 887.)

Edit: Should -1978334957 be added too?

@stephengillie stephengillie added Needs-Author-Feedback This needs a response from the author. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Aug 14, 2024
@jbne
Copy link
Contributor Author

jbne commented Aug 14, 2024

Maybe? It seems to correspond to APPINSTALLER_CLI_ERROR_INSTALL_SYSTEM_NOT_SUPPORTED, is that something being returned from the Winget CLI instead of the installer? Would adding that to the .yml even get around that issue?

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Aug 14, 2024
@stephengillie
Copy link
Collaborator

Manual Validation ended with the same errors.
Nvidia.GRID.x64.538.46.log

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Installation-Error Error installing application labels Aug 16, 2024
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-No-Executables labels Aug 16, 2024
@stephengillie
Copy link
Collaborator

Hi @jbne,

This set of switches seems not to modify the filesystem at all:
image

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Aug 19, 2024
@jbne
Copy link
Contributor Author

jbne commented Aug 19, 2024

@stephengillie

I'm not entirely sure what to do about this one since this will only install successfully on specific Azure VM SKUs: https://learn.microsoft.com/en-us/azure/virtual-machines/windows/n-series-driver-setup#nvidia-gridvgpu-drivers

My last change I made the exit code specific to "platform not supported" an expected successful code, which at least doesn't result in a failure in the pipeline but is also the reason why it did not modify the filesystem:

InstallerSuccessCodes:
- 3858759936

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Aug 19, 2024
@Trenly
Copy link
Contributor

Trenly commented Aug 19, 2024

[Policy] Hardware

@microsoft-github-policy-service microsoft-github-policy-service bot added the Hardware Specific hardware is required to install or validate this package label Aug 19, 2024
Copy link
Contributor

Hello @jbne,

This package appears to require specific hardware.

This PR is blocked until support for specific hardware requirements is implemented in:

Be sure to add your 👍 to the issue to help raise the priority and avoid posting "Me too!" messages to respect those who have subscribed to the issue.

Template: msftbot/blockingIssue/hardwareDependency

@microsoft-github-policy-service microsoft-github-policy-service bot added Blocking-Issue Manifest validation is blocked by a known issue. Needs-Author-Feedback This needs a response from the author. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Blocking-Issue Manifest validation is blocked by a known issue. Hardware Specific hardware is required to install or validate this package Needs-Author-Feedback This needs a response from the author. New-Package Validation-No-Executables
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Package Request]: Nvidia.GRID version 538.46
5 participants