Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: SomePythonThings.WingetUIStore.Pre-release version 3.1.0-beta0 #160131

Conversation

vikingnope
Copy link
Contributor

@vikingnope vikingnope commented Jun 26, 2024

Pull request has been created with komac v2.3.0 🚀

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Jun 26, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback This needs a response from the author. Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jun 26, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Installation failed with exit code 1

(Automated response - build 886.)

@vikingnope
Copy link
Contributor Author

@stephengillie check this manually please.

@stephengillie
Copy link
Collaborator

Hi @vikingnope,

This package installs and launches normally on a Windows 10 VM. Despite this, an exit code of 1 is returned:
image

Normally, I would remove the labels Needs-Attention This work item needs to be reviewed by a member of the core team. & Validation-Installation-Error Error installing application , and add Validation-Completed Validation passed - as I believe the package manager will silently fail and the install will complete, which is close to an ideal outcome. Should this PR proceed in this way?

@vikingnope
Copy link
Contributor Author

vikingnope commented Jun 27, 2024

This has happened in previous releases too as can be seen in the below screenshot. In my opinion it is fine to be released.

image

It also has this so I do not know why it is not completing correctly:

image

@stephengillie stephengillie added Validation-Completed Validation passed and removed Validation-Installation-Error Error installing application Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jun 28, 2024
@vikingnope
Copy link
Contributor Author

Thanks :)

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 658e813 into microsoft:master Jun 28, 2024
5 of 7 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jun 28, 2024
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@vikingnope vikingnope deleted the SomePythonThings.WingetUIStore.Pre-release-3.1.0-beta0-618EE80A5D32414689589C8CE110B88E branch July 5, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants