Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: NVIDIACorporation.NVIDIAapp version 1.0.14.0 #141787

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Barradel
Copy link
Contributor

@Barradel Barradel commented Mar 2, 2024

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@og-mrk
Copy link
Contributor

og-mrk commented Mar 4, 2024

There's a warning in the Azure Pipeline, which indicates that Silent and SilentWithProgress is not sprcified for exe InstallerType, maybe look into other installer types found in the repo's docs, to be exact, the ones found inside doc/manifest/schema/1.6.0 folder.

But the main reason for why this fails is probably because this app expects Nvidia GPU to be available in the system. Otherwise, the Install will fail. Therefore, it's highly a hardware issue, further investigation should be taken by Contributors and Maintainers, if any of which have the time to spare on testing this PR.

@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Installation failed with exit code -1978335226
2024-03-02 09:18:04.212 [CLI ] ShellExecute installer failed: 3858759680

(Automated response - build 857.)

@Barradel
Copy link
Contributor Author

Barradel commented Mar 4, 2024

Hi @stephengillie ! Like said @og-mrk, this fails is probably because this app expects Nvidia GPU to be available in the system.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Mar 4, 2024
@stephengillie
Copy link
Collaborator

stephengillie commented Mar 5, 2024

Hi @Barradel,

Unfortunately yes, this appears to be the case:

NVIDIA APP - requires an NVIDIA GPU.

@microsoft-github-policy-service microsoft-github-policy-service bot added Hardware Specific hardware is required to install or validate this package Blocking-Issue Manifest validation is blocked by a known issue. Needs-Author-Feedback This needs a response from the author. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Mar 5, 2024
@og-mrk
Copy link
Contributor

og-mrk commented Mar 5, 2024

Hello @stephengillie, thanks for responding to this issue.
I'm wondering on a workaround.. Could we add ExpectedReturnCodes and some Context for User when this happens?
like the code snippet below

ExpectedReturnCodes:
  - InstallerReturnCode: 3858759680
    ReturnResponse: systemNotSupported

Or do we have to wait for winget-cli support for hardware to be implemented?

@Barradel
Copy link
Contributor Author

Barradel commented Mar 5, 2024

Hello @stephengillie, thanks for responding to this issue. I'm wondering on a workaround.. Could we add ExpectedReturnCodes and some Context for User when this happens? like the code snippet below

ExpectedReturnCodes:
  - InstallerReturnCode: 3858759680
    ReturnResponse: systemNotSupported

Or do we have to wait for winget-cli support for hardware to be implemented?

Good idea!

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Mar 5, 2024
@stephengillie
Copy link
Collaborator

Hi @og-mrk and @Barradel,

That's an interesting proposal - it might make a good Issue - to unblock Hardware labeled PRs by adding a warning when the hardware is not present. A problem here is that if the installer won't install in the validation pipeline, then it can't have Defender and other scans performed on it, which is a critical part of our process. Here is the Issue for upgrading the validation pipeline VMs to include OpenGL:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking-Issue Manifest validation is blocked by a known issue. Hardware Specific hardware is required to install or validate this package Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Shell-Execute
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants