Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autogenerated/apple.boot camp drivers/b5211d2d b630 4028 b631 1719cad5afa9 #113306

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

upintheairsheep
Copy link
Contributor

@upintheairsheep upintheairsheep commented Jul 27, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: codeflow:open?pullrequest=#113306

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jul 27, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @upintheairsheep,

Please verify the manifest file is compliant with the package manager 1.0 manifest specification, 1.1 manifest specification, 1.2 manifest specification, or 1.4 manifest specification.

Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.

Note: The path and "PackageIdentifier" are case sensitive.

Be sure to use a tool like VSCode to make sure the manifest YAML syntax is correct. You can also validate your manifest using the winget validate command.

For details on the specific error, see the details link below in the build pipeline.

Template: msftbot/validationError/manifest/content

@upintheairsheep
Copy link
Contributor Author

Would like a validation screenshot.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Aug 1, 2023
@stephengillie
Copy link
Collaborator

Manifest: The manifest file path must match PackageIdentifier and PackageVersion properties from manifest. actual 'manifests\a\Apple\BootCampDrivers\5.0.5033', expected 'manifests\a\Apple\BootCampDrivers\5.1.5769'

@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Validation-Error Manifest validation failed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Aug 2, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service
Copy link
Contributor

Hello @upintheairsheep,

The package manager bot determined changes have been requested to your PR.

Template: msftbot/changesRequested

@ItzLevvie
Copy link
Contributor

ItzLevvie commented Aug 2, 2023

[Policy] Hardware

I'm seeing this on Windows Sandbox:
image

This might either be a Windows Sandbox issue or the installer has checks in place to identify whether the installer is being run on a Apple MacBook laptop or not.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Hardware Specific hardware is required to install or validate this package label Aug 2, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @upintheairsheep,

This package appears to require specific hardware.

This PR is blocked until support for specific hardware requirements is implemented in:

Be sure to add your 👍 to the issue to help raise the priority and avoid posting "Me too!" messages to respect those who have subscribed to the issue.

Template: msftbot/blockingIssue/hardwareDependency

@microsoft-github-policy-service microsoft-github-policy-service bot added the Blocking-Issue Manifest validation is blocked by a known issue. label Aug 2, 2023
@wingetbot wingetbot added the Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash label Aug 2, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @upintheairsheep,

I am sorry to report that the Sha256 Hash does not match the installer. This may be caused by using a vanity URL rather than a URL directly to the binary.

Please check the HASH and submit again. Sorry for the inconvenience.

Template: msftbot/validationError/installers/hashMismatch

…rs.installer.yaml

Co-authored-by: Levvie <11600822+ItzLevvie@users.noreply.github.com>
@microsoft-github-policy-service microsoft-github-policy-service bot removed Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash Blocking-Issue Manifest validation is blocked by a known issue. Needs-Author-Feedback This needs a response from the author. labels Aug 12, 2023
@ItzLevvie
Copy link
Contributor

[Policy] Blocking-Issue

@microsoft-github-policy-service microsoft-github-policy-service bot added the Blocking-Issue Manifest validation is blocked by a known issue. label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking-Issue Manifest validation is blocked by a known issue. Hardware Specific hardware is required to install or validate this package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants