Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Package: tastyworks.tastytrade version 2.3.1 #111750

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Jul 10, 2023

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 111750 in repo microsoft/winget-pkgs

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 111750 in repo microsoft/winget-pkgs

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jul 10, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Manifest-Validation-Error Manifest validation failed label Jul 10, 2023
@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jul 10, 2023
@BrandonWanHuanSheng
Copy link
Contributor

It look like you were max length with the schema. .

@Trenly
Copy link
Contributor Author

Trenly commented Jul 11, 2023

@stephengillie - This needs a manual review using the latest 1.5 release since the pipelines haven’t been updated with the new client yet

@BrandonWanHuanSheng
Copy link
Contributor

Remember, the yaml-language-server need to change 1.4.0 to 1.5.0
Also, I change on the ending header which is point to 1.5.0

@Trenly
Copy link
Contributor Author

Trenly commented Jul 11, 2023

Remember, the yaml-language-server need to change 1.4.0 to 1.5.0
Also, I change on the ending header which is point to 1.5.0

Either way the validation will still fail, since 1.5 manifests will be kicked back by the pipeline as invalid. The CLI handles this case just fine, it's just the schema validation that fails using the 1.4 schema

@BrandonWanHuanSheng
Copy link
Contributor

Remember, the yaml-language-server need to change 1.4.0 to 1.5.0
Also, I change on the ending header which is point to 1.5.0

Either way the validation will still fail, since 1.5 manifests will be kicked back by the pipeline as invalid. The CLI handles this case just fine, it's just the schema validation that fails using the 1.4 schema

Oh, I see.

@BrandonWanHuanSheng
Copy link
Contributor

I just testing in draft to see. If the pipelines still happening. But I actually got a validation succeed coming from
winget validate --manifest "F:\manifests\t\tastyworks\tastytrade\2.3.1"
Manifest validation succeeded.

F:>winget
Windows Package Manager v1.5.1881

@stephengillie stephengillie self-assigned this Jul 11, 2023
@stephengillie stephengillie added Validation-Completed Validation passed and removed Manifest-Validation-Error Manifest validation failed labels Jul 11, 2023
@microsoft-github-policy-service
Copy link
Contributor

Trenly,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@stephengillie
Copy link
Collaborator

stephengillie commented Jul 11, 2023

Automatic Validation ended with:

Manifest Error: Schema Error [Schema validation failed. Error context: [InstallationNotes] Description: String should be no more than 256 characters in length. Error context: Description: Failed to validate against schema associated with property name 'InstallationNotes'. ] File: tastyworks.tastytrade.locale.en-US.yaml

@stephengillie stephengillie removed their assignment Jul 11, 2023
@Trenly
Copy link
Contributor Author

Trenly commented Jul 11, 2023

Automatic Validation ended with:

Manifest Error: Schema Error [Schema validation failed. Error context: [InstallationNotes] Description: String should be no more than 256 characters in length. Error context: Description: Failed to validate against schema associated with property name 'InstallationNotes'. ] File: tastyworks.tastytrade.locale.en-US.yaml

@stephengillie - I'm aware of that; This has been resolved in the latest version of the CLI;
Thanks for the manual review!

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jul 12, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 584bdac into microsoft:master Jul 12, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello Trenly,
Validation has completed.

Template: msftbot/validationCompleted

@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@Trenly Trenly deleted the Tastytrade branch July 13, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Moderator-Approved One of the Moderators has reviewed and approved this PR Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Update Request]: tastyworks/tastytrade
4 participants