-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Package: tastyworks.tastytrade version 2.3.1 #111750
New Package: tastyworks.tastytrade version 2.3.1 #111750
Conversation
/AzurePipelines run |
No commit pushedDate could be found for PR 111750 in repo microsoft/winget-pkgs |
/AzurePipelines run |
No commit pushedDate could be found for PR 111750 in repo microsoft/winget-pkgs |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
It look like you were max length with the schema. . |
@stephengillie - This needs a manual review using the latest 1.5 release since the pipelines haven’t been updated with the new client yet |
Remember, the yaml-language-server need to change 1.4.0 to 1.5.0 |
manifests/t/tastyworks/tastytrade/2.3.1/tastyworks.tastytrade.installer.yaml
Show resolved
Hide resolved
manifests/t/tastyworks/tastytrade/2.3.1/tastyworks.tastytrade.installer.yaml
Show resolved
Hide resolved
manifests/t/tastyworks/tastytrade/2.3.1/tastyworks.tastytrade.locale.en-US.yaml
Show resolved
Hide resolved
manifests/t/tastyworks/tastytrade/2.3.1/tastyworks.tastytrade.locale.en-US.yaml
Show resolved
Hide resolved
Either way the validation will still fail, since 1.5 manifests will be kicked back by the pipeline as invalid. The CLI handles this case just fine, it's just the schema validation that fails using the 1.4 schema |
Oh, I see. |
I just testing in draft to see. If the pipelines still happening. But I actually got a validation succeed coming from F:>winget |
Trenly, The check-in policies require a moderator to approve PRs from the community. Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission. Template: msftbot/requiresApproval/moderator |
Automatic Validation ended with:
|
@stephengillie - I'm aware of that; This has been resolved in the latest version of the CLI; |
Hello Trenly, Template: msftbot/validationCompleted |
Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present. |
Microsoft Reviewers: codeflow:open?pullrequest=#111750