Update SandboxTest.ps1 #106266
Merged
Update SandboxTest.ps1 #106266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Trenly, Changes to one or more files in your PR require authorization to modify. This PR has been assigned to our on call staff to evaluate. Template: msftbot/requiresApproval/MSFT |
russellbanks
approved these changes
May 9, 2023
microsoft-github-policy-service
bot
added
the
Moderator-Approved
mdanish-kh
approved these changes
May 9, 2023
denelon
approved these changes
May 9, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SandboxTest.ps1 currently only has
-PreReleaseto select a version of winget. This is great, but it re-downloads winget every time you switch between using-PreReleaseand not using it. This PR changes how the script detects winget versions. Instead of checking theSandboxTestfolder for the winget appx, this change now makes it use the same directory thatWingetVersionManager.ps1uses. This way, if the user already has the version available in their directory structure, it doesn't need to be downloaded at all. Once the proper appx has been selected, it is then copied to theSandboxTestfolder.This PR also changes how the SHA and download URL for Winget are fetched - meaning that only a single call is made to GitHub API's instead of two calls, so that a new switch for selecting the Winget version can be implemented in a separate PR.
cc @mdanish-kh @SpecterShell @russellbanks @denelon
Microsoft Reviewers: Open in CodeFlow