Search only by command and update main error handling #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Note for me: the Terminal CNF should also be updated |
DHowett
approved these changes
Oct 8, 2025
Member
|
update that Terminal CNF! |
DHowett
pushed a commit
to microsoft/terminal
that referenced
this pull request
Oct 9, 2025
## Summary of the Pull Request Update the WinGet CNF package search to match that of the updated PowerShell WinGet CNF module. Now, we'll only search for matching commands instead of by name and moniker. ## References and Relevant Issues microsoft/winget-command-not-found#29 ## Validation Steps Performed ✅ In CMD, type "vim" and vim packages are suggested
DHowett
pushed a commit
to microsoft/terminal
that referenced
this pull request
Nov 24, 2025
## Summary of the Pull Request Update the WinGet CNF package search to match that of the updated PowerShell WinGet CNF module. Now, we'll only search for matching commands instead of by name and moniker. ## References and Relevant Issues microsoft/winget-command-not-found#29 ## Validation Steps Performed ✅ In CMD, type "vim" and vim packages are suggested (cherry picked from commit 819987c) Service-Card-Id: PVTI_lADOAF3p4s4BBcTlzgfuACY Service-Version: 1.24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the WinGet search more strict in that it only searches for a strict match by command. This removes the blocking calls from various searches, which was the root cause of #24.
This also prevents the scenario where a package is suggested, but the newly installed package doesn't actually fix the issue of a command not being found. In searching only by command, the newly installed package is guaranteed to introduce the missing command unless the WinGet package catalog was wrong.
Additionally, the
catchblock was updated to remove the known MSIX issue, which has now been fixed. Instead, we display the caught exception. This should help further debug issues like #23.Closes #13
Closes #24