Update PowerShell Module Dependency Docs #2797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Issue-Bug
florelis
reviewed
Dec 22, 2022
florelis
reviewed
Dec 22, 2022
florelis
approved these changes
Dec 22, 2022
denelon
reviewed
Dec 22, 2022
florelis
reviewed
Dec 22, 2022
| @@ -6,6 +6,15 @@ This project contains the source code for building the Windows Package Manager P | |||
|
|
|||
| After building the project solution, the `Microsoft.WinGet.Client` PowerShell module can be found in the output directory in the `PowerShell` folder. For example if you built the project as x64 release, you should expect to find the module files in `$(SolutionDirectory)/src/x64/Release/PowerShell`. | |||
|
|
|||
| ## Prerequisites | |||
|
|
|||
| The PowerShell module has a dependency on the Microsoft Visual C++ Redistributable package which can be downloaded [here](https://learn.microsoft.com/en-US/cpp/windows/latest-supported-vc-redist?view=msvc-170) or installed through WinGet by running the following command: | |||
There was a problem hiding this comment.
What version do I need to download?
There was a problem hiding this comment.
@florelis I've got the Microsoft Visual C++ 2015-2022 Redistributable, v14.34.31931 on my W11 machine, both x86 and x64, and it works for me (well, it imports and Get-WinGetPackage runs). I suspect you can just go with x64 though.
There was a problem hiding this comment.
I added the word "latest" and the id in the winget example points to 2015.
There was a problem hiding this comment.
Thanks @robinmalik. I actually meant it as a rhetorical question for @ryfu-msft to specify it in the doc, which he did
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2795
Changes:
Updates the PowerShell module documentation to explicitly identify the required dependency on the Microsoft Visual C++ Redistributable package in order to run the cmdlets
Microsoft Reviewers: Open in CodeFlow