Don't treat the COM subcommands as distinct for telemetry #2792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florelis
approved these changes
Dec 21, 2022
There were two activities, and I didn't need a particularly helpful name since this was a short fix. |
florelis
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Calls to COM install/upgrade were logging the distinct steps (download/install) as separate commands under the same activity. This was leading to an incorrect success metric due to the method of processing.
Change
This change treats the
OrchestratorQueueItemas the command for telemetry purposes. This aligns with thewinget.exemethod of counting success/failure. It also moves to use the same command names aswinget.exe, making it easier to join/slice the data.Validation
Using an ETW event tracer, manually verified the current bad state. Then verified that the change produces a single start/stop pair under the same activity for an install.
Microsoft Reviewers: Open in CodeFlow