Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow upgrade for unknown version packages #2747

Merged
merged 3 commits into from
Dec 6, 2022
Merged

Allow upgrade for unknown version packages #2747

merged 3 commits into from
Dec 6, 2022

Conversation

ryfu-msft
Copy link
Contributor

@ryfu-msft ryfu-msft commented Dec 6, 2022 •
edited by ghost
Loading

Fixes: #2714

Changes:

  • Fixes an issue where the --include-unknown argument was unable to be combined with query arguments (--id, --name etc.)
  • Added unit tests for verifying the behavior of the --include-unknown argument.
Microsoft Reviewers: Open in CodeFlow

@ryfu-msft ryfu-msft requested a review from a team as a code owner December 6, 2022 07:16
@ghost ghost added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Dec 6, 2022
@ryfu-msft ryfu-msft changed the title Allow upgrade for unknown version package(s) Allow upgrade for unknown version packages Dec 6, 2022
@ryfu-msft ryfu-msft merged commit b025a3f into microsoft:master Dec 6, 2022
@ryfu-msft ryfu-msft deleted the includeUnknownBug branch December 6, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yao-msft yao-msft yao-msft approved these changes

Assignees
No one assigned
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't upgrade a package whose version number is unknown
2 participants
@ryfu-msft @yao-msft