Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logo to README.md #2507

Merged
merged 5 commits into from
Sep 12, 2022
Merged

Add logo to README.md #2507

merged 5 commits into from
Sep 12, 2022

Conversation

vedantmgoyal9
Copy link
Contributor

@vedantmgoyal9 vedantmgoyal9 commented Sep 11, 2022 •
edited by ghost
Loading

cc @denelon

Microsoft Reviewers: Open in CodeFlow

@vedantmgoyal9 vedantmgoyal9 requested a review from a team as a code owner September 11, 2022 11:45
@ghost ghost added the Issue-Feature This is a feature request for the Windows Package Manager client. label Sep 11, 2022
@vedantmgoyal9
Copy link
Contributor Author

@denelon Issue-Docs It's a documentation issue that really should be on MicrosoftDocs

@denelon
Copy link
Contributor

denelon commented Sep 11, 2022

Why is the "#" being replaced with HTML? This is a markdown file.

@Trenly
Copy link
Contributor

Trenly commented Sep 11, 2022

Why is this referencing https://user-images.githubusercontent.com/ and not .github/images ? If it's an official logo, it should be stored in this repo

@vedantmgoyal9
Copy link
Contributor Author

Why is the "#" being replaced with HTML? This is a markdown file.

To align it with the heading, since markdown doesn't support height and width parameters.

@denelon denelon merged commit f9fc158 into microsoft:master Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denelon denelon denelon approved these changes

Assignees
No one assigned
Labels
Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vedantmgoyal9 @denelon @Trenly