Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Labels from Hash Command #2431

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Update Labels from Hash Command #2431

merged 1 commit into from
Aug 12, 2022

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Aug 9, 2022 •
edited by ghost
Loading

Microsoft Reviewers: Open in CodeFlow

@Trenly Trenly requested a review from a team as a code owner August 9, 2022 00:34
@ghost ghost added the Issue-Feature This is a feature request for the Windows Package Manager client. label Aug 9, 2022
florelis
florelis approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@florelis florelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming these are supposed to be the literal manifest field so that one can just copy-and-paste it into a yaml file. I think it would be good to add a comment about that so that we don't mistakenly localize the strings later.

@florelis
Copy link
Member

florelis commented Aug 9, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Trenly
Copy link
Contributor Author

Trenly commented Aug 9, 2022

I think it would be good to add a comment about that so that we don't mistakenly localize the strings later.

I thought that's what the Localization Independent View was for?
image

@florelis
Copy link
Member

florelis commented Aug 9, 2022

_liv does mean that it is supposed to be loc independent, but it doesn't say why. My first thought when I saw the change was to wonder why it wasn't localized like in the show command, if it was a leftover from when we didn't have localization, and if we needed to update.

The comment is not needed, I just prefer to err on the side of too many comments than too few.

@JohnMcPMS JohnMcPMS merged commit 75d47fc into microsoft:master Aug 12, 2022
@Trenly Trenly deleted the Issue938 branch August 12, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnMcPMS JohnMcPMS JohnMcPMS approved these changes

@florelis florelis florelis approved these changes

Assignees
No one assigned
Labels
Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update output text for hash values
3 participants
@Trenly @florelis @JohnMcPMS