Show PurchaseUrl if present in manifest #2416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnMcPMS
reviewed
Aug 10, 2022
Trenly
force-pushed
the
ShowPurchaseUrl
branch
from
f50c689
to
fb3fc18
Compare
Trenly
force-pushed
the
ShowPurchaseUrl
branch
from
6514864
to
ad68ba6
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ryfu-msft
approved these changes
Aug 23, 2022
|
Looks good to me, will defer to @yao-msft for sign-off and merge |
yao-msft
reviewed
Aug 23, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not take into account any of the entitlement checking for the MSStore source; The only change this should have is to Pre-Indexed and Rest sources where, if the PurchaseUrl is present in the manifest, the URL will be displayed.
As part of this I have also taken the many if statements for checking if fields are empty and moved them into a function for ease of readability.
Loosely related to #1345
Microsoft Reviewers: Open in CodeFlow